Hide trash icon when collapsing or expanding a block#4298
Merged
walterbender merged 2 commits intosugarlabs:masterfrom Jan 22, 2025
Merged
Hide trash icon when collapsing or expanding a block#4298walterbender merged 2 commits intosugarlabs:masterfrom
walterbender merged 2 commits intosugarlabs:masterfrom
Conversation
Contributor
Author
|
@walterbender Sir, please check it. |
subhas-pramanik-09
changed the title
Collaborator
|
I tested it, and it does seem to be an improvement. |
Ubayed-Bin-Sufian
pushed a commit
to Ubayed-Bin-Sufian/musicblocks
that referenced
this pull request
Jan 24, 2025
* Hide trash pop-up when collapsing or expanding a block * Hide trash pop-up when collapsing or expanding a block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #3849
In this issue mentioned that the delete icon pop-up when we collapse or expand a block but the collapse and expand works properly. Only issue that the trash icon pop-up when expanding or collapsing a block.
In this PR, the trash icon not appears when the block is collapsed or expanded and only pop-up when we perform other interaction with block.
Screen.Recording.2025-01-22.003110.mp4